Reply to thread

Message

[QUOTE="shanmugapradeep, post: 242656, member: 70475"]
Thanks for verifying. I tested again and it look working.

[B]Code 1 : [/B]

[CODE=mql4]void CheckMovingAverageConditions()
  {
   gMovingAverageSignal = "NoSignal";
   bool conditionsUp[7], conditionsDown[7];
   ENUM_TIMEFRAMES periods[7];
   int count = 0;

if(PeriodM1)
      periods[count++] = PERIOD_M1;
   if(PeriodM5)
      periods[count++] = PERIOD_M5;
   if(PeriodM15)
      periods[count++] = PERIOD_M15;
   if(PeriodM30)
      periods[count++] = PERIOD_M30;
   if(PeriodH1)
      periods[count++] = PERIOD_H1;
   if(PeriodH4)
      periods[count++] = PERIOD_H4;
   if(PeriodD1)
      periods[count++] = PERIOD_D1;

if(count == 0)
      return;  // Exit if no timeframes are selected

bool allTrueUp = true, allTrueDown = true;
   double bidPrice = MarketInfo(gRandomSymbol, MODE_BID);
   double askPrice = MarketInfo(gRandomSymbol, MODE_ASK);

for(int i = 0; i < count; i++)
     {
      double MA_Value = iMA(gRandomSymbol, periods[i], MovingAverage_Period, MovingAverage_MAShift, MovingAverage_Method, MovingAverage_AppliedPrice, MovingAverage_Shift);
      
      conditionsUp[i]   = (bidPrice > MA_Value);
      conditionsDown[i] = (askPrice < MA_Value);

allTrueUp   &= conditionsUp[i];   // If any condition is false, allTrueUp becomes false
      allTrueDown &= conditionsDown[i]; // If any condition is false, allTrueDown becomes false
     }

if(allTrueUp)
      gMovingAverageSignal = "ABOVE";
   if(allTrueDown)
      gMovingAverageSignal = "BELOW";
  }[/CODE]

[B]Code 2 : [/B]

[CODE=mql4]void CheckMovingAverageConditions()
  {
   gMovingAverageSignal = "NoSignal";
   ENUM_TIMEFRAMES periods[7];
   int count = 0;

if(PeriodM1)  periods[count++] = PERIOD_M1;
   if(PeriodM5)  periods[count++] = PERIOD_M5;
   if(PeriodM15) periods[count++] = PERIOD_M15;
   if(PeriodM30) periods[count++] = PERIOD_M30;
   if(PeriodH1)  periods[count++] = PERIOD_H1;
   if(PeriodH4)  periods[count++] = PERIOD_H4;
   if(PeriodD1)  periods[count++] = PERIOD_D1;

if(count == 0)
      return;  // Exit if no timeframes are selected

bool allTrueUp = true, allTrueDown = true;
   double bidPrice = MarketInfo(gRandomSymbol, MODE_BID);
   double askPrice = MarketInfo(gRandomSymbol, MODE_ASK);

for(int i = 0; i < count; i++)
     {
      double MA_Value = iMA(gRandomSymbol, periods[i], MovingAverage_Period, MovingAverage_MAShift, MovingAverage_Method, MovingAverage_AppliedPrice, MovingAverage_Shift);
      
      if(bidPrice <= MA_Value)
         allTrueUp = false;   // If any fails, set allTrueUp to false
      if(askPrice >= MA_Value)
         allTrueDown = false; // If any fails, set allTrueDown to false
     }

if(allTrueUp)
      gMovingAverageSignal = "ABOVE";
   else if(allTrueDown)
      gMovingAverageSignal = "BELOW";
  }
[/CODE]

Is code 1 and code 2 do exactly same operation? Checking indicator according different timeframe together? If, both do same function, which one should i use for better performance, speed execution and accuracy?
[/QUOTE]

Verification