How do you usually exeute trades calculated by Position Size Calculator?

  • Manually

    Votes: 12 15.2%
  • PSC-Trader script with a mouse click

    Votes: 13 16.5%
  • PSC-Trader with a keyboard shortcut

    Votes: 51 64.6%
  • Using third-party trading panel

    Votes: 2 2.5%
  • Other (please provide details)

    Votes: 1 1.3%

  • Total voters
    79
  • Poll closed .
Status
Not open for further replies.

Chistabo

Active Trader
Apr 13, 2015
16
1
29
Slovenia
Hi, Envid & Co., very nice work with PSC v2.
Please check 'Swaps' tab, 'Nominal' row, 'Short' column - it shows too many numbers, it is not NormalizeDouble.

Best regards,

Simon
S love nia
 

Vitor Herva

Active Trader
Dec 16, 2016
17
0
27
43
Hello everybody!

I`m new here and I have two doubts:

1- How can I do to this fantatic inticator works well with DAX?

2- I`m trying a crazy thing (just to learn), and I change the indicato to EA.
It was easy and fast, but the problem is, when I change the time frame more than 3 times, the indicator panel was crazy, like the picture.

Please, anybody can help me?

Error.JPG
 

Enivid

Administrator
Staff member
Nov 30, 2008
19,250
1,507
144
Odesa
www.earnforex.com
1- How can I do to this fantatic inticator works well with DAX?
And what is its problem with DAX?

It was easy and fast, but the problem is, when I change the time frame more than 3 times, the indicator panel was crazy, like the picture.
There is a lot of stuff to change if you want to make it a working EA. To fix this particular problem, you should look for errors in the Experts tab.
 

Chistabo

Active Trader
Apr 13, 2015
16
1
29
Slovenia
Here is the screenshot of PSC v2.03, Swaps tab, Nominal Short value. It shows too much number.
Modifying PositionSizeCalculator.mqh (line 784) -

MQL4:
   /* Swaps Nominal Long             */ if (!m_EdtSwapsNominalLong.Text(DoubleToString(swap_long, 2)))                           return(false); // swap_long_decimal_places
   /* Swaps Nominal Short            */ if (!m_EdtSwapsNominalShort.Text(DoubleToString(swap_short, 2)))                         return(false); // swap_short_decimal_places

displays only 2 decimal places.
Using Pepperstone broker, EUR USD pair.

Best regards,

Simon
 

Attachments

  • PSC 2,03 - Swaps tab - Nominal Short value.png
    PSC 2,03 - Swaps tab - Nominal Short value.png
    15.2 KB · Views: 7
  • 👍
Reactions: Enivid

Enivid

Administrator
Staff member
Nov 30, 2008
19,250
1,507
144
Odesa
www.earnforex.com
Thanks for reporting! I will address this bug in the next version. Unfortunately, just normalizing it to 2 decimal places is not a proper solution as the number of decimal places in the swap varies.
 

Vitor Herva

Active Trader
Dec 16, 2016
17
0
27
43
And what is its problem with DAX?

The problem is the LotSize, is vary big, not a correct calculation!

There is a lot of stuff to change if you want to make it a working EA. To fix this particular problem, you should look for errors in the Experts tab.

I'm send a image:
 

Attachments

  • Erro.png
    Erro.png
    80.6 KB · Views: 9

Chistabo

Active Trader
Apr 13, 2015
16
1
29
Slovenia
Unfortunately, just normalizing it to 2 decimal places is not a proper solution as the number of decimal places in the swap varies.
Yea, but for huge majority of users it shall do, since swaps are presented in currency form, for which 2 places shall do. Please explain why do you need more digits? Just curious.

Simon
S love nia
 

Chistabo

Active Trader
Apr 13, 2015
16
1
29
Slovenia

Me neither see any problem. From the right side of picture it can be seen that price is around 11412, and (brilliant and neat) PSCv2 shows calculations around that price. Except for small position size, all settings/calculations look fine.
 

Chistabo

Active Trader
Apr 13, 2015
16
1
29
Slovenia
Now the code to run in Expert mode.
I changed just the "PositionSizeCalculator.mq4"

What are trying to achieve? Merge PSCScript with PSCv2? Please explain the purpose of this EA.

Simon
S love nia
 

Enivid

Administrator
Staff member
Nov 30, 2008
19,250
1,507
144
Odesa
www.earnforex.com
Yea, but for huge majority of users it shall do, since swaps are presented in currency form, for which 2 places shall do. Please explain why do you need more digits? Just curious.

Swaps are not always presented in currency form. Sometimes, they are in percentage so the values can be 3 or 4 decimal places.
 

Enivid

Administrator
Staff member
Nov 30, 2008
19,250
1,507
144
Odesa
www.earnforex.com
Here is the screenshot of PSC v2.03, Swaps tab, Nominal Short value. It shows too much number.
Modifying PositionSizeCalculator.mqh (line 784) -

MQL4:
   /* Swaps Nominal Long             */ if (!m_EdtSwapsNominalLong.Text(DoubleToString(swap_long, 2)))                           return(false); // swap_long_decimal_places
   /* Swaps Nominal Short            */ if (!m_EdtSwapsNominalShort.Text(DoubleToString(swap_short, 2)))                         return(false); // swap_short_decimal_places

displays only 2 decimal places.
Using Pepperstone broker, EUR USD pair.

If you need a quick fix for this, I'd recommend changing the following line in PositionSizeCalculator.mqh:
MQL4:
if (MathFloor(number) == number) return(i);
to:
MQL4:
if (MathAbs(MathRound(number) - number) <= FLT_EPSILON) return(i);
 

Vitor Herva

Active Trader
Dec 16, 2016
17
0
27
43
What are trying to achieve? Merge PSCScript with PSCv2? Please explain the purpose of this EA.

Simon
S love nia

Hello!
I'm learning, so I want to combine in the EA the PSC Script with PSC.
Can you help me with this very strange and difficult problem?
 
Status
Not open for further replies.